RFR: 8282526: Default icon is not painted properly [v4]

Alexander Zuev kizune at openjdk.java.net
Mon Jun 6 22:55:40 UTC 2022


On Fri, 27 May 2022 18:02:51 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Detect the situation where we do need to perform interpolation during ImageIcon
>> painting and set a hint to the rendering to perform bicubic approximation so
>> image details are preserved during transition.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use small icon pointer for icons less than 24 pixels wide - this way we
>   get the 16x16 icon which is better for scaling purposes.

Here, in the name of resolving this issue finally i have reverted the ImageIcon changes, instead i added some code that creates the properly scaled version of icon when requested variant is not available. Plus i have fixed the small icon retrieval so it is not an issue anymore.

I am not going trough all the experiments with the SHDefExtractIcon  again - at least not in this pull request. I checked and there is no performance impact at all from the latest changes on the 100% scaled screens due to the extracting an additional icon - looks like Windows extracts it anyways even if we specify null as a icon information reference - it just does not pass it down.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7805



More information about the client-libs-dev mailing list