RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v3]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Mon Mar 14 13:18:55 UTC 2022


On Mon, 14 Mar 2022 12:39:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting changes to test case
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaLookAndFeel.java line 892:
> 
>> 890:             "Table.focusCellBackground", textHighlightText,
>> 891:             "Table.focusCellForeground", textHighlight,
>> 892:             "Table.focusCellHighlightBorder", new BorderUIResource.LineBorderUIResource(deriveContrastFocusRing(selectionBackground), 2),
> 
> You have used border thickness as 2 without relying on scale factor. Did you check if it looks same in retina as well as non-retina display?

Do we also need to do the same for List.focusCellHighlightBorder?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7768



More information about the client-libs-dev mailing list