RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v3]
Harshitha Onkar
duke at openjdk.java.net
Mon Mar 14 22:25:47 UTC 2022
On Mon, 14 Mar 2022 13:14:15 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> src/java.desktop/macosx/classes/com/apple/laf/AquaLookAndFeel.java line 892:
>>
>>> 890: "Table.focusCellBackground", textHighlightText,
>>> 891: "Table.focusCellForeground", textHighlight,
>>> 892: "Table.focusCellHighlightBorder", new BorderUIResource.LineBorderUIResource(deriveContrastFocusRing(selectionBackground), 2),
>>
>> You have used border thickness as 2 without relying on scale factor. Did you check if it looks same in retina as well as non-retina display?
>
> Do we also need to do the same for List.focusCellHighlightBorder?
@prsadhuk Thank you for reviewing.
Earlier when I used the default thickness (thickness=1) the cell focus ring was visible but not prominent as shown in the following screenshot. Please let me know if I need to change thickness to 1 or keep it the same?
**Thickness=1**

The thickness looks the same on retina as well as non-retina display. I have included the screenshots for comparison-

-------------
PR: https://git.openjdk.java.net/jdk/pull/7768
More information about the client-libs-dev
mailing list