RFR: 8283712 : Create a manual test framework class

[Phil Race]

On Fri, 25 Mar 2022 21:06:12 GMT, lawrence.andrews <duke at openjdk.java.net> wrote:

> We need a common manual test framework code that can be shared across all the client manual test. This framework class should have the following
> 1) Frame which contains test instruction .
> 2) Pass & Fail button so that user can mark the test pass or fail
> 3) Upon failing the test user should be able to elaborate why the test failed and this can be added to the test failure. 
> 4) Disposing of all the frames.
> 
> @aivanov-jdk

This really needs to be delivered in the same PR as something using it so it can actually be tested.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 42:

> 40:     private JTextArea instructionsText;
> 41:     private int maxStringLength = 50;
> 42:     private int timeoutMinutes = 3;

why can't this be configured ?

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 68:

> 66:         setLocationRelativeTo(null);
> 67:         setVisible(true);
> 68:     }

Hmm. Why can't this be wrapped in invokeAndWait to save the test having to do it ?

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 76:

> 74:             System.out.println(f.getTitle() + " is getting disposed");
> 75:             f.dispose();
> 76:         }

Same here for invokeAndWait ?
You just need to document that these shouldn't be called on the EDT ..
in fact you need to document the threading regardless.

Mind you I am not sure this code should be destroying all frames.
It is a  non-obvious side effect ..

-------------

Changes requested by prr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7966