RFR: 8283712 : Create a manual test framework class [v2]

lawrence.andrews duke at openjdk.java.net
Sat Mar 26 02:13:26 UTC 2022


On Fri, 25 Mar 2022 21:35:49 GMT, Phil Race <prr at openjdk.org> wrote:

>> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed the review comments and fixed the test using PassFailJFrame.java
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 76:
> 
>> 74:             System.out.println(f.getTitle() + " is getting disposed");
>> 75:             f.dispose();
>> 76:         }
> 
> Same here for invokeAndWait ?
> You just need to document that these shouldn't be called on the EDT ..
> in fact you need to document the threading regardless.
> 
> Mind you I am not sure this code should be destroying all frames.
> It is a  non-obvious side effect ..

Added the documentation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7966



More information about the client-libs-dev mailing list