RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same." [v2]

[Phil Race]

On Wed, 4 May 2022 11:04:50 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test used to fail in specific CI macos M1 system owing to miniscule color difference 
>> 
>> 
>> x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184
>> x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue2 185
>> x 0 y 2 red1 173 red2 174 green1 177 green2 178 blue1 187 blue2 187
>> x 0 y 6 red1 0 red2 0 green1 1 green2 0 blue1 0 blue2 0
>> x 0 y 15 red1 1 red2 0 green1 0 green2 0 blue1 0 blue2 0
>> 
>> 
>> SInce we already have color-tolerance check present, there is no need of exact color value check.
>> Also, made the frame undecorated and remove unneeded library being built. 
>> Several iterations of the test passed in the same system (where it used to fail 4/10) along with other platforms (link in JBS)
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reduce color tolerance

OK so .. there's a difficulty facing this test. It has NO idea where the icon is. 
It randomly captures a chunk of the title bar and for Aqua it doesn't even come close to grabbing a single pixel
of the icon  - it is 100 pixels or more off.

So we are not comparing what we want to be comparing. It is pointless.

I think you need to come up with a way to make sure you are grabbing the right place which is L&F dependent ...

If you can't then you might as well scrap this useless test which is really just comparing pixels from the title bar.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8380