RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v8]

Kevin Rushforth kcr at openjdk.java.net
Fri May 13 19:31:50 UTC 2022


On Fri, 13 May 2022 19:16:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/java.desktop/windows/classes/sun/awt/windows/WTrayIconPeer.java line 2:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 2005, 2022, Oracle and/or its affiliates. All rights reserved.
>> 
>> You can revert this file, since the only remaining changes are this copyright year and import statements, which are relating to your fix.
>
> I'm for keeping the expanded imports in WTrayIconPeer.java, even it's the only change left now.
> 
> I'd probably remove the unused import from `TrayIcon.java` too. However, the change in this case is too minor.

My preference would be to revert it. Once all of the actual changes associated with this fix were reverted, fixing the imports (or any similar type cleanup) in a file that otherwise doesn't need to be touched at all becomes an unrelated change. Maybe Phil can weigh in on this point.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8441



More information about the client-libs-dev mailing list