RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v8]
Alexey Ivanov
aivanov at openjdk.java.net
Fri May 13 19:37:42 UTC 2022
On Fri, 13 May 2022 19:28:26 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> I'm for keeping the expanded imports in WTrayIconPeer.java, even it's the only change left now.
>>
>> I'd probably remove the unused import from `TrayIcon.java` too. However, the change in this case is too minor.
>
> My preference would be to revert it. Once all of the actual changes associated with this fix were reverted, fixing the imports (or any similar type cleanup) in a file that otherwise doesn't need to be touched at all becomes an unrelated change. Maybe Phil can weigh in on this point.
Your approach makes the changeset _cleaner_, I agree. Nothing's changed in these two files. Better to avoid touching them and creating confusion. Let's leave these clean-up changes until the files are modified.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8441
More information about the client-libs-dev
mailing list