RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

Harshitha Onkar honkar at openjdk.java.net
Tue May 24 17:54:57 UTC 2022


On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Test was failing intermiitently in iMac M1 system owing to minimalistic color difference of 1 
> 
> x 13 y 0 refRGB ffeeeeee customRGB ffefeeee
> x 0 y 0 refRGB ffefefef customRGB ffefeeef
> 
> 
> so added color tolerance check. 
> Also, added other stability fixes..
> Several iteration of test passed in intended M1 and x64 system.

test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java line 64:

> 62: 
> 63:     public static void main(String[] args) throws Exception {
> 64:         if (!System.getProperty("os.name").toLowerCase().contains("os x")) {

@prsadhuk Since the tag **@requires (os.family == "mac")** is added, is this check necessary or is it added for standalone testing purpose?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8864



More information about the client-libs-dev mailing list