RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Wed May 25 02:59:51 UTC 2022


On Tue, 24 May 2022 17:51:27 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Test was failing intermiitently in iMac M1 system owing to minimalistic color difference of 1 
>> 
>> x 13 y 0 refRGB ffeeeeee customRGB ffefeeee
>> x 0 y 0 refRGB ffefefef customRGB ffefeeef
>> 
>> 
>> so added color tolerance check. 
>> Also, added other stability fixes..
>> Several iteration of test passed in intended M1 and x64 system.
>
> test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java line 64:
> 
>> 62: 
>> 63:     public static void main(String[] args) throws Exception {
>> 64:         if (!System.getProperty("os.name").toLowerCase().contains("os x")) {
> 
> @prsadhuk Since the tag **@requires (os.family == "mac")** is added, is this check necessary or is it added for standalone testing purpose?

Yes for standalone testing for which I also removed dependancy on jtreg Platform class

-------------

PR: https://git.openjdk.java.net/jdk/pull/8864



More information about the client-libs-dev mailing list