RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v2]

Harshitha Onkar honkar at openjdk.java.net
Fri May 27 17:06:52 UTC 2022


On Wed, 25 May 2022 12:21:51 GMT, Tejesh R <duke at openjdk.java.net> wrote:

>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Updated based on review comments
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8286620
>  - Moving bug4380543.java from closed to open
>  - Merge branch 'master' of github.com:TejeshR13/jdk
>  - Merge branch 'openjdk:master' into master
>  - Merge remote-tracking branch 'upstream/master'
>  - Merge remote-tracking branch 'upstream/master'
>  - Merge branch 'master' of github.com:TejeshR13/jdk
>  - Initial Commit.

Tested on Win10, visually the insets look fine. Minor formatting changes suggested.

test/jdk/javax/swing/JRadioButton/bug4380543.java line 24:

> 22:  */
> 23: /* @test
> 24:    @bug 4380543

We usually have "*" for all the jtreg header lines similar to copyright

test/jdk/javax/swing/JRadioButton/bug4380543.java line 51:

> 49: import java.util.Map;
> 50: 
> 51: public class bug4380543 {

Based on previous test class name reviews, we usually follow non-bug id names.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8721



More information about the client-libs-dev mailing list