RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v2]

Tejesh R duke at openjdk.java.net
Fri May 27 17:21:36 UTC 2022


On Fri, 27 May 2022 17:03:08 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Updated based on review comments
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8286620
>>  - Moving bug4380543.java from closed to open
>>  - Merge branch 'master' of github.com:TejeshR13/jdk
>>  - Merge branch 'openjdk:master' into master
>>  - Merge remote-tracking branch 'upstream/master'
>>  - Merge remote-tracking branch 'upstream/master'
>>  - Merge branch 'master' of github.com:TejeshR13/jdk
>>  - Initial Commit.
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 24:
> 
>> 22:  */
>> 23: /* @test
>> 24:    @bug 4380543
> 
> We usually have "*" for all the jtreg header lines similar to copyright

Accepted and updated.

> test/jdk/javax/swing/JRadioButton/bug4380543.java line 51:
> 
>> 49: import java.util.Map;
>> 50: 
>> 51: public class bug4380543 {
> 
> Based on previous test class name reviews, we usually follow non-bug id names.

Yeah, but since its an existing regression test which is been moved here, keeping the same test/class names would be better I feel. It would also help in traceability in future I guess.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8721



More information about the client-libs-dev mailing list