RFR: 6972078: Can not select single directory with GTKLookAndFeel [v2]
Abhishek Kumar
duke at openjdk.org
Thu Nov 3 12:04:14 UTC 2022
On Thu, 27 Oct 2022 09:27:00 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>>> Can you also please test it works ok (or atleast not regress) for other selection mode FILES_ONLY, DIRECTORIES_ONLY in the test?
>>
>> Verified for file selection mode of `DIRECTORIES_ONLY`, test passed for all LAFs.
>>
>> In case of selection mode of `FILES_ONLY`, test is failing for all LAFs. The reason behind this is we are trying to select `Directory `when selection mode is set to `FILES_ONLY`.
>>
>>> Can you then please enhance the test to iterate for all installed L&Fs?
>>
>> Updated for all installed LAFs.
>
>> > Can you also please test it works ok (or atleast not regress) for other selection mode FILES_ONLY, DIRECTORIES_ONLY in the test?
>>
>> Verified for file selection mode of `DIRECTORIES_ONLY`, test passed for all LAFs.
>>
>> In case of selection mode of `FILES_ONLY`, test is failing for all LAFs. The reason behind this is we are trying to select `Directory `when selection mode is set to `FILES_ONLY`.
>
> I guess you can see in folders where you have only files...Testwise, maybe use File.createTempFile for creating files and see..
@prsadhuk As discussed, created the sub-test for all file selection mode. Checked with all LAFs and in CI pipeline, link is added in JBS.
-------------
PR: https://git.openjdk.org/jdk/pull/10866
More information about the client-libs-dev
mailing list