RFR: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails [v3]
Phil Race
prr at openjdk.org
Wed Nov 16 05:29:04 UTC 2022
On Wed, 16 Nov 2022 05:16:02 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
>> This test was failing because of color difference on boundaries. Updated test case to not check edges and added color tolerance.
>>
>> Also updated test to:
>> 1) Use standard GraphicsConfiguration bounds for image instead of constant numbers.
>> 2) Use waitForIdle before screen capture and added auto delay
>> 3) Move mouse pointer away from rendering content (In my local Mac it failed every time when mouse pointer was present over test frame)
>> 4) Remove usage of insets as it is undecorated and remove windows closing listener
>> 5) Dispose frame when test fails
>>
>> With these changes test is not failing in CI with multiple runs on all platforms.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
>
> Use EDT for creation of frame and dispose frame in finally block
Marked as reviewed by prr (Reviewer).
test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java line 95:
> 93: }
> 94: });
> 95: // wait for Vista's effects to complete
I wonder what this (obsolete?) comment was about - please delete, and I'm not sure what waiting there is.
-------------
PR: https://git.openjdk.org/jdk/pull/11158
More information about the client-libs-dev
mailing list