RFR: 8294807: Fix typos and clarify javadoc for SunToolKit.realsSync

Sergey Bylokhov serb at openjdk.org
Sat Oct 8 15:33:36 UTC 2022


On Thu, 6 Oct 2022 23:23:21 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> src/java.desktop/share/classes/sun/awt/SunToolkit.java line 1451:
>> 
>>> 1449:      *
>>> 1450:      * <p> This method allows writing tests without explicit timeouts
>>> 1451:      * or waiting for some event.  Example:
>> 
>> Should it be “without _using_ … or waiting …”?  
>> Does “for an event” sound better?
>
> In my opinion, "without using ... or waiting ..." seems better to match the tense of "waiting" to show more clearly what the "or" is intended for (assuming the OR is meant for the explicit timeouts and the waiting for an event).
> 
> Otherwise, the "or" may be confused to be between "writing ... or waiting ...".
> 
> For the "event" portion, I think either here is OK. I don't think either would cause confusion and both sound reasonable.

I do not think we should recommend as of now the usage of the internal API in the tests.

-------------

PR: https://git.openjdk.org/jdk/pull/10563



More information about the client-libs-dev mailing list