RFR: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure [v3]

Alisen Chung achung at openjdk.org
Fri Oct 14 20:42:57 UTC 2022


On Tue, 11 Oct 2022 18:54:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> The previous change to AquaComboBoxUI had 1 pixel of overlap between the text field and the combo button. This caused a few pixels to darken sometimes when an editable combobox is displayed. Since this test passes sometimes and fails some other times, it was not initially detected.
>> 
>> Since these few darkening pixels occur due to the change in AquaComboBoxUI, no reasonable change to the test could really be made, and the change would need to be to the class for the combobox. This fix was tested with a high count repeat and no failures occurred for various macOS systems.
>> 
>> Also removing the test from the problem list.
>
> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch '8294254/overlapFixEditableCombobox' of github.com:DamonGuy/jdk into 8294254/overlapFixEditableCombobox
>  - Set uiscale

Looks fine

-------------

Marked as reviewed by achung (Author).

PR: https://git.openjdk.org/jdk/pull/10626



More information about the client-libs-dev mailing list