Integrated: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
Damon Nguyen
dnguyen at openjdk.org
Tue Oct 18 03:59:37 UTC 2022
On Mon, 10 Oct 2022 05:26:23 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
> The previous change to AquaComboBoxUI had 1 pixel of overlap between the text field and the combo button. This caused a few pixels to darken sometimes when an editable combobox is displayed. Since this test passes sometimes and fails some other times, it was not initially detected.
>
> Since these few darkening pixels occur due to the change in AquaComboBoxUI, no reasonable change to the test could really be made, and the change would need to be to the class for the combobox. This fix was tested with a high count repeat and no failures occurred for various macOS systems.
>
> Also removing the test from the problem list.
This pull request has now been integrated.
Changeset: 358ac072
Author: Damon Nguyen <dnguyen at openjdk.org>
Committer: Jayathirth D V <jdv at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/358ac07255cc640cbcb9b0df5302d97891a34087
Stats: 8 lines in 3 files changed: 2 ins; 3 del; 3 mod
8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
Reviewed-by: jdv, achung
-------------
PR: https://git.openjdk.org/jdk/pull/10626
More information about the client-libs-dev
mailing list