RFR: 8295554: Move the "sizecalc.h" to the correct location

Phil Race prr at openjdk.org
Sun Oct 23 00:41:10 UTC 2022


On Thu, 20 Oct 2022 04:15:33 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> The "sizecalc.h" file is moved out from java.desktop/share/native/include, the files in that folder appear in the jdk bundle after installation like the "jawt.h".
>
> make/common/modules/LauncherCommon.gmk line 48:
> 
>> 46: LAUNCHER_SRC := $(TOPDIR)/src/java.base/share/native/launcher
>> 47: LAUNCHER_CFLAGS += -I$(TOPDIR)/src/java.base/share/native/launcher \
>> 48:     -I$(TOPDIR)/src/java.desktop/share/native/include \
> 
> This line was added recently, not sure why.

Hmm .. IIRC Alex Zuev said  there is a (closed) native test and adding this was the only way he could make that test work .. 
Now clearly this location no longer makes sense when the file is moved, but someone will need to do something about the test. It needs Alex to chime in here.

-------------

PR: https://git.openjdk.org/jdk/pull/10757



More information about the client-libs-dev mailing list