RFR: 8293811: Provide a reason for PassFailJFrame.forceFail

Jayathirth D V jdv at openjdk.org
Thu Sep 15 05:09:04 UTC 2022


On Wed, 14 Sep 2022 16:27:36 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Add `forceFail` implementation which allows passing the reason why the test is failed.
> 
> I used the newly added method `forceFail(reason)` instead of throwing an exception in `PrintAllPagesTest`. When the test is run outside of jtreg and printing is cancelled, the the test UI becomes “hung”: clicking Pass or Fail or closing windows does not stop the test.
> 
> I also converted the `ret` field to local variable.
> 
> In addition to this, I reduced the size of the test frame, its size of 1000×800 doesn't fit even full HD screens when positioned close to the instruction frame.

If there are other tests where we can use PassFailJFrame.forceFail(String) instead of throwing RuntimeException, we should raise a bug and keep it for tracking.

LGTM.

-------------

Marked as reviewed by jdv (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10269



More information about the client-libs-dev mailing list