RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v4]

ExE Boss duke at openjdk.org
Thu Apr 6 03:27:21 UTC 2023


On Wed, 5 Apr 2023 21:36:57 GMT, Glavo <duke at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/util/Architecture.java line 77:
>> 
>>> 75:      */
>>> 76:     @ForceInline
>>> 77:     public static boolean isARM() {
>> 
>> It should define what’s the difference to aarch64 for example will aarch64 also be arm, but arm32 wont? (Or remove)
>
>> It should define what’s the difference to aarch64 for example will aarch64 also be arm, but arm32 wont? (Or remove)
> 
> I think x86 and ARM are a bit confusing in this regard, as they can refer to 32-bit architectures in a narrow sense and 32-bit or 64 bit architectures in a broad sense.
> 
> For clarity, we can use more specific names: `x86-32`/`i686` and `arm32`/`aarch32`. But these names don't seem to be that commonly used.

Suggestion:

    public static boolean isARM32() {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1159243677



More information about the client-libs-dev mailing list