RFR: 8305920 : Replace String concatenation in a loop in SimpleAttributeSet.toString with StringBuilder

Phil Race prr at openjdk.org
Fri Apr 14 16:52:35 UTC 2023


On Fri, 14 Apr 2023 15:59:32 GMT, Renjith Kannath Pariyangad <duke at openjdk.org> wrote:

> Replaced string concatenation using '+' operator with StringBuilder append function.
> 
> Please review.
> 
> Regards,
> Renjith.

Why is this important ? How often is toString() used on this class ?
IDE suggestions are more relevant when they are pointing to YOUR code that you are developing.
It has to be really important to go changing 20 year old stable code.
This seems like pointless code churn to me.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13479#pullrequestreview-1385816721



More information about the client-libs-dev mailing list