RFR: 8305920 : Replace String concatenation in a loop in SimpleAttributeSet.toString with StringBuilder

Tue Apr 18 08:47:56 UTC 2023

On Fri, 14 Apr 2023 16:50:04 GMT, Phil Race <prr at openjdk.org> wrote:

>> Replaced string concatenation using '+' operator with StringBuilder append function.
>> 
>> Please review.
>> 
>> Regards,
>> Renjith.
>
> Why is this important ? How often is toString() used on this class ?
> IDE suggestions are more relevant when they are pointing to YOUR code that you are developing.
> It has to be really important to go changing 20 year old stable code.
> This seems like pointless code churn to me.

Thank you @prrace for the review, I will close this commit.

Renjith

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13479#issuecomment-1512697471