RFR: 8071693: Introspector ignores default interface methods [v4]
Phil Race
prr at openjdk.org
Thu Apr 20 19:32:44 UTC 2023
On Thu, 20 Apr 2023 14:22:47 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:
>> The `Introspector` class was never updated to include `default` methods inherited from interfaces.
>>
>> This patch attempts to fix that omission.
>
> Archie L. Cobbs has updated the pull request incrementally with two additional commits since the last revision:
>
> - Verify static method is not mistakenly identified as property getter.
> - Use Modifier.isAbstract() convenience method instead of bit masking test.
The fix overall looks fine, but I'm not seeing why you think it needs a CSR.
It is just a bug fix. And if there were a CSR, it would be about the visible change, not the internals.
-------------
PR Review: https://git.openjdk.org/jdk/pull/13544#pullrequestreview-1394632684
More information about the client-libs-dev
mailing list