RFR: 8306137: Open source several AWT ScrollPane related tests
Phil Race
prr at openjdk.org
Tue Apr 25 02:50:11 UTC 2023
On Mon, 24 Apr 2023 19:22:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Open source few AWT ScrollPane related tests.
>
> test/jdk/java/awt/ScrollPane/ScrollPaneWindowsTest/ScrollPaneWindowsTest.java line 91:
>
>> 89: System.out.println("This test is for Windows 2000/2003/XP only.");
>> 90: return;
>> 91: }
>
> Again, use `OSInfo` or better `@requires` tag.
The whole comment needs reworking and thinking about.
Is it trying to say this test is obsolete after XP ?
In which case since even the successors of Visa, WIndows 7, 8 and 8.1 are all dead
the comment is really really unwelcome in 2023. And perhaps the test is too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13621#discussion_r1175958311
More information about the client-libs-dev
mailing list