RFR: 8306137: Open source several AWT ScrollPane related tests

Tejesh R tr at openjdk.org
Tue Apr 25 05:51:21 UTC 2023


On Tue, 25 Apr 2023 02:47:39 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/java/awt/ScrollPane/ScrollPaneWindowsTest/ScrollPaneWindowsTest.java line 91:
>> 
>>> 89:             System.out.println("This test is for Windows 2000/2003/XP only.");
>>> 90:             return;
>>> 91:         }
>> 
>> Again, use `OSInfo` or better `@requires` tag.
>
> The whole comment needs reworking and thinking about.
> Is it trying to say this test is obsolete after XP ?
> In which case since even the successors of Visa, WIndows 7, 8 and 8.1 are all dead
> the comment is really really unwelcome in 2023. And perhaps the test is too.

Ok, then I will not move the test, should it be left as applet or it should be removed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13621#discussion_r1176029217



More information about the client-libs-dev mailing list