RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v5]

[Sergey Bylokhov]

On Thu, 27 Jul 2023 03:46:23 GMT, Renjith Kannath Pariyangad <duke at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded invalid GUID and clipped description in windows(ID not found in registry). With com initialization library load proper GUID (same as registry).
>> 2. For Play back device always loading proper device GUID irrespective of com Initialization.
>> 
>> Test:
>> Since screen lock and unlock workflow required for reproducing this issue, did coupe of iteration of manual testing post fix and confirmed its resolving the problem.
>> To reconfirm nothing is broken, executed all audio related test cases on test bench post fix and all are green.
>> 
>> Please review the changes and let me know your comments if any.
>> 
>> Regards,
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added COM init for DAUDIO_GetDirectAudioDeviceDescription

src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp line 227:

> 225:         g_lastCacheRefreshTime = (UINT64) timeGetTime();
> 226:     }
> 227:     ::CoUninitialize();

I guess this should be called only if the CoInitialize returns S_OK or S_FALSE. It is also necessary to check what happens when the user(via JNI or any other API) initialized COM before using different "params" - I assume in this case CoInitialize in our code should return S_FALSE.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14898#discussion_r1280075585