RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v5]

Renjith Kannath Pariyangad duke at openjdk.org
Tue Aug 1 04:10:57 UTC 2023


On Tue, 1 Aug 2023 03:35:35 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added COM init for DAUDIO_GetDirectAudioDeviceDescription
>
> src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp line 227:
> 
>> 225:         g_lastCacheRefreshTime = (UINT64) timeGetTime();
>> 226:     }
>> 227:     ::CoUninitialize();
> 
> I guess this should be called only if the CoInitialize returns S_OK or S_FALSE. It is also necessary to check what happens when the user(via JNI or any other API) initialized COM before using different "params" - I assume in this case CoInitialize in our code should return S_FALSE.

Thank you for the review, added status check.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14898#discussion_r1280086605



More information about the client-libs-dev mailing list