RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v6]

Sergey Bylokhov serb at openjdk.org
Tue Aug 1 21:55:47 UTC 2023


On Tue, 1 Aug 2023 04:10:55 GMT, Renjith Kannath Pariyangad <duke at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded invalid GUID and clipped description in windows(ID not found in registry). With com initialization library load proper GUID (same as registry).
>> 2. For Play back device always loading proper device GUID irrespective of com Initialization.
>> 
>> Test:
>> Since screen lock and unlock workflow required for reproducing this issue, did coupe of iteration of manual testing post fix and confirmed its resolving the problem.
>> To reconfirm nothing is broken, executed all audio related test cases on test bench post fix and all are green.
>> 
>> Please review the changes and let me know your comments if any.
>> 
>> Regards,
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added CoInitialize status check

src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp line 262:

> 260:     }
> 261:     if(FAILED(::CoInitialize(NULL)))
> 262:         return false;

DS_unlockCache if the CoInitialize fails?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14898#discussion_r1281191116



More information about the client-libs-dev mailing list