RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v6]

Renjith Kannath Pariyangad duke at openjdk.org
Wed Aug 2 09:48:54 UTC 2023


On Tue, 1 Aug 2023 21:52:41 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added CoInitialize status check
>
> src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp line 262:
> 
>> 260:     }
>> 261:     if(FAILED(::CoInitialize(NULL)))
>> 262:         return false;
> 
> DS_unlockCache if the CoInitialize fails?

Thank you for pointing this, I have clubbed CoInitialize check along with other condition. In case of failure it will return there itself.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14898#discussion_r1281668482



More information about the client-libs-dev mailing list