RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v2]

[Alexey Ivanov]

On Wed, 9 Aug 2023 06:01:47 GMT, Tejesh R <tr at openjdk.org> wrote:

>> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`. Converting the `String `to `locale` before adding as command key fix the issue. 
>> I have verified the test in all other platforms and Look and Feel which has option to create New Folder, results were fine. No regressions found on CI system with the fix. Added manual test to verify the fix.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Proposed Fix

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 844:

> 842:             UIManager.getString("FileChooser.win32.newFolder");
> 843:     private static String newFolderNextString  =
> 844:             UIManager.getString("FileChooser.win32.newFolder.subsequent");

Should they be fields at all?
Declare them where they're used.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15069#pullrequestreview-1569534185
PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1288467725