RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v5]

[Abhishek Kumar]

On Thu, 31 Aug 2023 07:17:35 GMT, Tejesh R <tr at openjdk.org> wrote:

>> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`. Converting the `String `to `locale` before adding as command key fix the issue. 
>> I have verified the test in all other platforms and Look and Feel which has option to create New Folder, results were fine. No regressions found on CI system with the fix. Added manual test to verify the fix.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

test/jdk/javax/swing/JFileChooser/FileChooserNewFolderLocaleTest.java line 61:

> 59:             newFolderEnglish =
> 60:                     fileChooser.getFileSystemView().createNewFolder(currentDir);
> 61:             if(!newFolderEnglish.getName().contains(ENGLISH_NEW_FOLDER)) {

Suggestion:

            if (!newFolderEnglish.getName().contains(ENGLISH_NEW_FOLDER)) {

test/jdk/javax/swing/JFileChooser/FileChooserNewFolderLocaleTest.java line 66:

> 64: 
> 65:             UIManager.put(newFolderKey, FRENCH_NEW_FOLDER);
> 66:             UIManager.put(newFolderSubKey, FRENCH_NEW_FOLDER + " ({0})");

Suggestion:

            UIManager.put(newFolderSubKey, FRENCH_NEW_FOLDER + " ({0}) ");

Please put a space on either side else no space.

test/jdk/javax/swing/JFileChooser/FileChooserNewFolderLocaleTest.java line 70:

> 68:             newFolderFrench =
> 69:                     fileChooser.getFileSystemView().createNewFolder(currentDir);
> 70:             if(!newFolderFrench.getName().contains(FRENCH_NEW_FOLDER)) {

Suggestion:

            if (!newFolderFrench.getName().contains(FRENCH_NEW_FOLDER)) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1311442361
PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1311443175
PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1311443301