RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v5]

Alexey Ivanov aivanov at openjdk.org
Thu Aug 31 14:14:01 UTC 2023


On Thu, 31 Aug 2023 10:42:47 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/javax/swing/JFileChooser/FileChooserNewFolderLocaleTest.java line 66:
> 
>> 64: 
>> 65:             UIManager.put(newFolderKey, FRENCH_NEW_FOLDER);
>> 66:             UIManager.put(newFolderSubKey, FRENCH_NEW_FOLDER + " ({0})");
> 
> Suggestion:
> 
>             UIManager.put(newFolderSubKey, FRENCH_NEW_FOLDER + " ({0}) ");
> 
> Please put a space on either side else no space.

It is wrong to add the space here, you add to the string value, it shouldn't be there.

Perhaps, you can drop `newFolderSubKey` from the test, you don't test the case where two or more folders are created.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1311694265


More information about the client-libs-dev mailing list