RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix

Alexey Ivanov aivanov at openjdk.org
Tue Dec 5 18:22:33 UTC 2023


On Thu, 30 Nov 2023 03:34:08 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

> Hi Reviewers, 
> There was a typo for color conversion instead of dstColorSpace function srcColorSpace was used. Please review and let me know your suggestions if any. 
> 
> Renjith.

The fix looks good to me.

I agree with @mrserb, it would be good to create a test case. I don't have much experience with color transforms, so I don't have any pointers as to how to create one. If it takes a considerable amount of time, I guess it's fine to go without the test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16895#issuecomment-1841358386


More information about the client-libs-dev mailing list