RFR: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation

Alexey Ivanov aivanov at openjdk.org
Tue Dec 5 18:33:34 UTC 2023


On Mon, 20 Nov 2023 23:58:30 GMT, Phil Race <prr at openjdk.org> wrote:

> Whilst reviewing the fix for https://bugs.openjdk.org/browse/JDK-7001133 I realised that although the proposed
> changes there may help, the problem would be inconsequential except that if anything causes an app to
> call PrintService.getAttributes()  we will continually be re-initialising attributes, which causes IPPPrintService
> to keep creating new instances of CUPSPrinter which are then discarded and over-written.
> So update the implementation to only re-initialise the relevant attributes.

Looks good to me.

Could you update the copyright year in `IPPPrintService.java`?

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16752#pullrequestreview-1765850140


More information about the client-libs-dev mailing list