RFR: 8318590: JButton ignores margin when painting HTML text [v5]

Tue Dec 5 19:22:46 UTC 2023

On Tue, 5 Dec 2023 19:05:12 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> > @DamonGuy Reverted changes fixes the issue. Since you are reverting #12520, shouldn't the corresponding test HtmlButtonWithTextAndIcon.java be reverted too? Copyright years need to be updated for some files.
> 
> Alexander brought up the same question. After discussion, we decided to keep the test. The test is still valid & passes, so we could leave it in.

So this fix https://github.com/openjdk/jdk/pull/12520 was due to a prior fix https://github.com/openjdk/jdk/pull/8407 but the test remains valid in original case as well. Makes sense now as to why HtmlButtonWithTextAndIcon.java is retained.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16869#issuecomment-1841471863