Integrated: 8318590: JButton ignores margin when painting HTML text
Damon Nguyen
dnguyen at openjdk.org
Tue Dec 5 19:28:43 UTC 2023
On Tue, 28 Nov 2023 23:40:45 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
> The initial issue was a padding issue for JButton when HTML content was set as the button's text. [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772), [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and [JDK-8302173](https://bugs.openjdk.org/browse/JDK-8302173) are the issues related to the fix. The initial bug report was for Metal L&F, since it has a drastically different button margin from the rest (2, 14, 2, 14). This left and right margin of 14px led to the initial bug report. However, it was determined that the issue was not an issue, and instead, a problem with the reporter's implementation since they weren't aware of the difference in Metal's button margins versus other L&Fs.
>
> This PR reverts these changes since it was determined in [this PR](https://github.com/JFormDesigner/FlatLaf/issues/746) that the fix causes a new issue regarding JButton contents' positioning.
This pull request has now been integrated.
Changeset: acaf2c8d
Author: Damon Nguyen <dnguyen at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/acaf2c8dcfd5235f758af2fe3e308b72263113e4
Stats: 193 lines in 4 files changed: 8 ins; 177 del; 8 mod
8318590: JButton ignores margin when painting HTML text
Reviewed-by: prr, azvegint, honkar
-------------
PR: https://git.openjdk.org/jdk/pull/16869
More information about the client-libs-dev
mailing list