RFR: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array" [v6]

Alexey Ivanov aivanov at openjdk.org
Tue Dec 5 19:32:40 UTC 2023


On Tue, 5 Dec 2023 19:21:52 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`. For `DIRECTORIES_ONLY `mode, there may not be any directories in home directory and due to that test failed. Added the code to create temporary directories and files for the test.
>> Tested the current change on the machine it failed for multiple times, no failure observed.
>> CI link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused imports

Changes requested by aivanov (Reviewer).

test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java line 2:

> 1: /*
> 2:  * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.

You always preserve the first year.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16674#pullrequestreview-1765952402
PR Review Comment: https://git.openjdk.org/jdk/pull/16674#discussion_r1416183017


More information about the client-libs-dev mailing list