RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v3]

[Alexey Ivanov]

On Tue, 5 Dec 2023 20:13:50 GMT, Phil Race <prr at openjdk.org> wrote:

>> For as long as we've had the macOS port, it seems that queries on the GraphicsConfiguration associated with
>> a printer would give you null for the defaultTransform.
>> Clearly this API isn't a popular one to call in such a context else we'd have had lots of reports.
>> We have a test that would have caught it except that until recently the macOS printing implementation
>> was swallowing exceptions it should not.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8320443

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 109:

> 107:         GraphicsDevice gd = gConfig.getDevice();
> 108:         System.out.println("Printer Device ID = " + gd.getIDstring());
> 109:         if (!(gd.getType() == GraphicsDevice.TYPE_PRINTER)) {

Suggestion:

        if (gd.getType() != GraphicsDevice.TYPE_PRINTER) {

It looks cleaner this way. I missed it when I went over the code the first time.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16773#pullrequestreview-1766050543
PR Review Comment: https://git.openjdk.org/jdk/pull/16773#discussion_r1416242507