RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v3]

Phil Race prr at openjdk.org
Tue Dec 5 20:38:52 UTC 2023


On Tue, 5 Dec 2023 20:28:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8320443
>
> test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 109:
> 
>> 107:         GraphicsDevice gd = gConfig.getDevice();
>> 108:         System.out.println("Printer Device ID = " + gd.getIDstring());
>> 109:         if (!(gd.getType() == GraphicsDevice.TYPE_PRINTER)) {
> 
> Suggestion:
> 
>         if (gd.getType() != GraphicsDevice.TYPE_PRINTER) {
> 
> It looks cleaner this way. I missed it when I went over the code the first time.

yes that would be cleaner. updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16773#discussion_r1416248417


More information about the client-libs-dev mailing list