RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v19]

Prasanta Sadhukhan psadhukhan at openjdk.org
Wed Feb 15 05:29:13 UTC 2023


On Tue, 14 Feb 2023 11:55:05 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test alignment
>
> test/jdk/javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java line 103:
> 
>> 101:                               "PropertyChangeListeners called with " +
>> 102:                                "state STARTED before doInBackground is finished");
>> 103:                     }
> 
> The comments, conditions and error messages do not match.
> 
> In the first case, it should be `doInBackgroundStarted` instead of `doInBackgroundFinished`; in the second — `doInBackgroundFinished` correspondingly.
> 
> Or the error messages should be swapped.
> 
> Did you mean anything else?

Test is updated to test the order

-------------

PR: https://git.openjdk.org/jdk/pull/11940



More information about the client-libs-dev mailing list