RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v5]

Tejesh R tr at openjdk.org
Thu Jan 12 04:55:15 UTC 2023


On Wed, 11 Jan 2023 19:49:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Spacing updation
>
> test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 83:
> 
>> 81:             return;
>> 82:         }
>> 83:         if (customApproveButton.getText() == null) {
> 
> Now that you test that the text on the Approve is non-null only, why is Aqua L&F excluded?

Since in aqua the fallback text is handled already and in aqua there is a sub panel which handles the Approve button, I excluded it.

-------------

PR: https://git.openjdk.org/jdk/pull/11901



More information about the client-libs-dev mailing list