RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v5]
Tejesh R
tr at openjdk.org
Thu Jan 12 06:26:15 UTC 2023
On Thu, 12 Jan 2023 04:52:32 GMT, Tejesh R <tr at openjdk.org> wrote:
>> test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 83:
>>
>>> 81: return;
>>> 82: }
>>> 83: if (customApproveButton.getText() == null) {
>>
>> Now that you test that the text on the Approve is non-null only, why is Aqua L&F excluded?
>
> Since in aqua the fallback text is handled already and in aqua there is a sub panel which handles the Approve button, I excluded it.
Also, `getDefaultApproveButton()` returns null for Aqua L&F, to include Aqua in the test we can use `getApproveButtonText()`.
-------------
PR: https://git.openjdk.org/jdk/pull/11901
More information about the client-libs-dev
mailing list