RFR: JDK-8302618: [MacOS] Problem typing uppercase letters with java.awt.Robot when moving mouse [v2]

Alexey Ivanov aivanov at openjdk.org
Mon Jul 3 20:30:54 UTC 2023


On Mon, 3 Jul 2023 04:45:38 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   kCGEventFlagMaskSecondaryFn added
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CRobot.m line 426:
> 
>> 424: }
>> 425: 
>> 426: static inline int GetCGKeyMask(int cgKeyCode)
> 
> Suggestion:
> 
> static inline int GetCGKeyMask(int cgKeyCode) {

I disagree: the common style throughout this file is to put the opening brace on the following line. A few lines above, `GetCGKeyCode` follows the same style.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14744#discussion_r1251261953



More information about the client-libs-dev mailing list