RFR: JDK-8302618: [MacOS] Problem typing uppercase letters with java.awt.Robot when moving mouse [v2]

Harshitha Onkar honkar at openjdk.org
Mon Jul 3 21:30:56 UTC 2023


On Mon, 3 Jul 2023 20:28:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/java.desktop/macosx/native/libawt_lwawt/awt/CRobot.m line 426:
>> 
>>> 424: }
>>> 425: 
>>> 426: static inline int GetCGKeyMask(int cgKeyCode)
>> 
>> Suggestion:
>> 
>> static inline int GetCGKeyMask(int cgKeyCode) {
>
> I disagree: the common style throughout this file is to put the opening brace on the following line. A few lines above, `GetCGKeyCode` follows the same style.

@aivanov-jdk Yeah, I wasn't sure of open brace placement in native - some methods follow Java-style of having the open brace on the same line and few others have it on the next line. Will revert it in the next commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14744#discussion_r1251290246



More information about the client-libs-dev mailing list