RFR: 8310054: ScrollPane insets are incorrect

Alexey Ivanov aivanov at openjdk.org
Thu Jul 6 11:01:09 UTC 2023


On Thu, 22 Jun 2023 21:31:52 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> I guess we should call "s->VerifyState();" after the "s->SetInsets(env);" similar to what we do in the "AwtScrollPane::_SetInsets"

@mrserb An interesting question… You're right, I've introduced an inconsistency.

Yet I don't think it matters because `SetInsets` doesn't change any members of `AwtScrollPane` object which are asserted in `VerifyState`. In addition to it, `VerifyState` is a no-op in release builds.

I'll take this into account in [JDK-8310056](https://bugs.openjdk.org/browse/JDK-8310056).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14478#discussion_r1254275679



More information about the client-libs-dev mailing list