RFR: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel [v2]
Tejesh R
tr at openjdk.org
Tue Jul 11 04:19:20 UTC 2023
On Tue, 20 Jun 2023 20:33:32 GMT, Phil Race <prr at openjdk.org> wrote:
>>> This change will have broad impact everywhere the Border is used. And it seems to me to be a workaround for the problem that Metal isn't correctly calculating the length of the text at the scaled resolution.
>>
>> It is possible that the width of the sting isn't calculated correctly, which could explain “cut off” label. At the same time, the text flushed to the very edge doesn't look either. When there's a margin, text looks better and is easier to read. Perhaps, we should address both issues.
>
>> > This change will have broad impact everywhere the Border is used. And it seems to me to be a workaround for the problem that Metal isn't correctly calculating the length of the text at the scaled resolution.
>>
>> It is possible that the width of the sting isn't calculated correctly, which could explain “cut off” label. At the same time, the text flushed to the very edge doesn't look either. When there's a margin, text looks better and is easier to read. Perhaps, we should address both issues.
>
> So long as such a margin doesn't just become another workaround fix, so
>
> Step 1 - measure it correctly
> Step 2 - add a pixel of clear margin space for added aesthetics.
@prrace @aivanov-jdk @kumarabhi006 Any comments on this PR?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14464#issuecomment-1630084595
More information about the client-libs-dev
mailing list