IMPORTANT REMINDER: 2 Reviews (ie approvals) are required for most client-libs changes

Philip Race philip.race at oracle.com
Thu Jul 13 15:27:55 UTC 2023


Please see "Code Reviews" on the Group page
https://openjdk.org/groups/client-libs/ where it says

The Java Client Library Group has always standardized on two approvals - 
where at least one must have the Reviewer role.
Historically this was addressed entirely by social conventions but today 
the tooling plays a role - and the JDK project is set up to mark a PR as 
ready for integration after a single approval by a person with the 
Reviewer role - which is not consistent with the Client Libraries policy.
The tooling cannot automatically enforce this on a per-module basis and 
it is not reasonable to expect others to add "/reviewers 2" to every PR.
The fixer therefore needs to understand the policies and wait for a 
second approval.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

As an example of a PR about which there was zero urgency and should have 
had a 2nd approval see

https://github.com/openjdk/jdk/pull/14795

-phil.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20230713/61f26b96/attachment.htm>


More information about the client-libs-dev mailing list