RFR: 8296920: Regression Test DialogOrient.java fails on MacOS
Jayathirth D V
jdv at openjdk.org
Mon Jun 5 09:08:08 UTC 2023
On Fri, 12 May 2023 09:03:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> Test was failing with PrinterException: Wrong Orientation since printing was done with default orientation.
> Fix is made to set the printable with correct PageFormat
>
> It was not seen prior to [JDK-8262731](https://bugs.openjdk.org/browse/JDK-8262731) probably because the exception was being swallowed..
Please add latest copyright year before pushing.
Was able to reproduce the issue and its fix.
I can see why we need to pass our PageFormat to setPrintable().
Strange that, we have this "landscape" variable and it is not used to pass appropriate page format. Test update seems fine.
-------------
Marked as reviewed by jdv (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13950#pullrequestreview-1462073152
More information about the client-libs-dev
mailing list