Integrated: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows

Tejesh R tr at openjdk.org
Fri Jun 2 04:33:23 UTC 2023


On Tue, 16 May 2023 06:40:20 GMT, Tejesh R <tr at openjdk.org> wrote:

> This is a regression from fix [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of symlink is null in JFileChooser. The fix checks whether the file path is a symbolic link using `Files.isSymbolicLink()` method with path as input. In windows for specific folders like "This PC"/"Network"/"Libraries" the path value will be a hex values which causes InvalidPathException. In order to resolve the issue, since no other checks are available to validate the path of these folders, checking if the file is link firstly and then for symbolic link resolves the problem (since File.isLink() doesn't take path as input rather file is a parameter). Since every symbolic link is a link, this fix seems logical to me.
> The fix is tested in CI for regression and is green. The regression fix is also tested for confirmation and works fine.

This pull request has now been integrated.

Changeset: 325940b0
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/325940b0919e649e84358db35a55b3ac5dfe0acf
Stats:     103 lines in 3 files changed: 93 ins; 6 del; 4 mod

8307105: JFileChooser InvalidPathException when selecting some system folders on Windows

Reviewed-by: aivanov, abhiscxk, dnguyen

-------------

PR: https://git.openjdk.org/jdk/pull/13998



More information about the client-libs-dev mailing list