RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v15]
Phil Race
prr at openjdk.org
Tue Jun 6 22:34:04 UTC 2023
On Fri, 2 Jun 2023 08:12:55 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() method which can fail due to missing implementation of equals method in CSS subclasses.
>> In this issue, even when two CSS AttributeSet has same 42 font size string value, Object equality fails.
>> Fixed by implementing the equality and hashCode method for CSS.FontSize class.
>>
>> All jtreg/jck tests are ok
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Optimization removed to use local variables for non-percentage units
Please confirm this test (and all other relevant tests) still pass.
Approving in anticipation of confirmation of the above.
-------------
Marked as reviewed by prr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13405#pullrequestreview-1466236272
More information about the client-libs-dev
mailing list